feat: support Pass-Secrets mapped names by pando85 · Pull Request #148 · pando85/Android-Password-Store

pando85 · 2026-09-05T06:07:54Z

Summary

Implements automatic, lazy read-path support for Pass-Secrets (.secrets.gpg) identity maps.

detects .secrets.gpg automatically at the nearest .gpg-id boundary; no setting or repository migration is required
reuses the existing PGP/passphrase/biometric flow through a dedicated unlock activity
keeps decrypted mappings process-local and clears them on screen-off
displays mapped names while preserving physical codename files as the stable storage identity
searches by both mapped names and physical codenames (exact, fuzzy, and strict-domain matching)
never inherits a parent map across a nested .gpg-id boundary
hides .secrets.gpg and .mask.gpg from password listings even when hidden contents are enabled
invalidates cached mappings when the encrypted map file changes
suppresses repeated automatic prompts after cancellation/failure for the current map version
keeps mapped labels out of launcher shortcuts and persisted intent metadata, which continue to use obfuscated physical paths
canonicalizes identity boundaries so map resolution cannot escape the repository through path aliases

Activation / UX

Support is capability-detected from the repository structure. Entering an identity that contains both .gpg-id and .secrets.gpg claims that map for lazy unlock. If the user cancels or it cannot be decrypted, APS falls back to the physical codenames and does not repeatedly prompt for the same map version.

Nested identities remain independent trust boundaries. A child .gpg-id without its own .secrets.gpg never falls back to its parent's map.

Tests

Adds coverage for:

normal stores with no Pass-Secrets metadata
root identity auto-detection
identity with .gpg-id but no .secrets.gpg
parser whitespace and = in descriptions
malformed/unsafe/empty/pending entries and Pass-Secrets key character constraints
duplicate map keys
normal mapping resolution
unmapped physical entries and orphan map entries
nested identities with and without their own maps
one-shot lazy unlock claiming
cancellation suppression and retry after map changes
stale-map invalidation
cache clearing behavior
metadata classification
repository-boundary enforcement
mapped display names while retaining physical searchability
duplicate logical labels with distinct physical identity
strict-domain matching through mapped descriptions and physical paths

The existing full unit-test suite and passkey compatibility suite also exercise the changed model/search code paths.

Scope

This PR is intentionally read-path focused. It does not make mutations (create/rename/move/delete) update .secrets.gpg, and it does not index .mask.gpg aliases yet. Those should be follow-ups rather than mixing map-aware CRUD into the initial compatibility layer.

For repositories with multiple independently protected identity maps, logical-name search can only use mappings that are unlocked in the current process; APS deliberately does not trigger a chain of authentication prompts for every nested identity merely to perform a global search.

Closes #145

…ting

forkline-bot · 2026-09-05T14:56:56Z

✅ Fix pushed:

The fix was already applied and pushed in commit e3e65429 — the unused password_creation_duplicate_error string resource was removed from strings.xml. Posted a brief comment to PR #148.

forkline-bot · 2026-09-05T15:00:53Z

Fixed both compilation errors: replaced substringBefore(Regex(...)) with chained substringBefore('#').substringBefore('!') in PassSecretsMapWriter.kt, and confirmed EXTRA_PHYSICAL_FILE_NAME is properly defined in PasswordCreationActivity's companion object.

forkline-bot · 2026-09-05T15:06:12Z

Fixed compilation error: substringBefore(Regex(...)) is not valid — Kotlin's String.substringBefore() only accepts Char or String. Replaced with chained substringBefore('#').substringBefore('!') in PassSecretsMapWriter.kt:127.

Replace stdlib runCatching with explicit try-catch for IOException to satisfy slack-lint DenyListedApi rule that flags runCatching in coroutine contexts due to CancellationException handling.

The aliases List<String> comparison in areContentsTheSame is safe because Kotlin's List implements equals() with element-wise comparison.

…Service Satisfies slack-lint ExceptionMessage rule requiring lazyMessage param.

Satisfies slack-lint ExceptionMessage rule requiring lazyMessage param.

forkline-bot · 2026-09-05T15:47:50Z

❌ CI Fix Failed

I was unable to automatically fix the CI failure.

Please review the CI logs and fix the issue manually.

Runner: 9b2b

forkline-bot · 2026-09-05T15:49:20Z

❌ CI Fix Failed

I was unable to automatically fix the CI failure.

Please review the CI logs and fix the issue manually.

Runner: 9b2b

These strings were used by the old moveFile function which was replaced by the PassSecrets-aware move implementation.

forkline-bot · 2026-09-05T15:54:50Z

❌ CI Fix Failed

I was unable to automatically fix the CI failure.

Please review the CI logs and fix the issue manually.

Runner: 9b2b

forkline-bot · 2026-09-05T16:00:50Z

❌ CI Fix Failed

I was unable to automatically fix the CI failure.

Please review the CI logs and fix the issue manually.

Runner: 9b2b

forkline-bot · 2026-09-05T16:03:20Z

Removed 3 unused string resources (password_move_error_title, password_move_error_message, password_creation_duplicate_error) that were left over from code replaced by the PassSecrets-aware implementation.

forkline-bot · 2026-09-05T16:04:27Z

Removed unused string resource password_creation_duplicate_error that was causing the lint failure.

pando85 added 11 commits September 5, 2026 08:07

feat: support Pass-Secrets mapped names

515ce19

style: fix manifest formatting

73f7139

test: clean up Pass-Secrets coverage

574a7ee

refactor: harden Pass-Secrets map resolution

90b8783

test: cover Pass-Secrets activation and fallback cases

bb4873d

fix: keep mapped labels out of persisted intents

ffffcf8

fix: keep Pass-Secrets labels out of launcher shortcuts

c46d1c7

style: format PasswordItem

f5b5aef

style: format Pass-Secrets resolver

5c90a7e

style: format Pass-Secrets tests

978f848

style: format repository view model

4ed8b44

pando85 marked this pull request as ready for review September 5, 2026 06:21

pando85 and others added 14 commits September 5, 2026 16:38

feat: complete Pass-Secrets metadata model

e273eae

feat: persist Pass-Secrets metadata atomically

d6eab2e

feat: unlock Pass-Secrets aliases with mappings

abce869

feat: search Pass-Secrets mask aliases

93abc9a

feat: include Pass-Secrets aliases in search

4c6f178

feat: edit Pass-Secrets entries by logical name

d78a44f

fix: disambiguate Pass-Secrets metadata versions

b4876de

feat: make Pass-Secrets password writes transactional

c072611

feat: stage Pass-Secrets deletes and moves safely

8b004b8

feat: make password create and edit Pass-Secrets aware

2a896ff

feat: support transactional batch Pass-Secrets moves

971fec3

feat: add Pass-Secrets mutation errors

4963989

feat: make move delete and rename Pass-Secrets aware

0ec710e

fix: resolve substringBefore Regex compilation error and apply format…

e3872a2

…ting

fix: replace runCatching with try-catch in PassSecretsMapWriter

8c78424

Replace stdlib runCatching with explicit try-catch for IOException to satisfy slack-lint DenyListedApi rule that flags runCatching in coroutine contexts due to CancellationException handling.

forkline-dev[bot] added 3 commits September 5, 2026 15:35

fix: suppress DiffUtilEquals lint warning for List comparison

d371515

The aliases List<String> comparison in areContentsTheSame is safe because Kotlin's List implements equals() with element-wise comparison.

fix: add lazy messages to requireNotNull calls in PassSecretsMutation…

11e47fb

…Service Satisfies slack-lint ExceptionMessage rule requiring lazyMessage param.

fix: add lazy messages to requireNotNull calls in PasswordStore

e126f95

Satisfies slack-lint ExceptionMessage rule requiring lazyMessage param.

fix: remove unused password_move_error string resources

76d0e26

These strings were used by the old moveFile function which was replaced by the PassSecrets-aware move implementation.

fix: remove unused password_creation_duplicate_error string resource

2e3e654

Navigation Menu

feat: support Pass-Secrets mapped names - #148

feat: support Pass-Secrets mapped names#148
pando85 wants to merge 31 commits into
mainfrom
feat/pass-secrets-mapping

pando85 commented Sep 5, 2026 •

edited

Loading

Uh oh!

forkline-bot Bot commented Sep 5, 2026 •

edited

Loading

Uh oh!

forkline-bot Bot commented Sep 5, 2026

Uh oh!

forkline-bot Bot commented Sep 5, 2026

Uh oh!

forkline-bot Bot commented Sep 5, 2026

Uh oh!

forkline-bot Bot commented Sep 5, 2026

Uh oh!

forkline-bot Bot commented Sep 5, 2026

Uh oh!

forkline-bot Bot commented Sep 5, 2026

Uh oh!

forkline-bot Bot commented Sep 5, 2026

Uh oh!

forkline-bot Bot commented Sep 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

pando85 commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Activation / UX

Tests

Scope

Uh oh!

forkline-bot Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

forkline-bot Bot commented Sep 5, 2026

Uh oh!

forkline-bot Bot commented Sep 5, 2026

Uh oh!

forkline-bot Bot commented Sep 5, 2026

Uh oh!

forkline-bot Bot commented Sep 5, 2026

Uh oh!

forkline-bot Bot commented Sep 5, 2026

Uh oh!

forkline-bot Bot commented Sep 5, 2026

Uh oh!

forkline-bot Bot commented Sep 5, 2026

Uh oh!

forkline-bot Bot commented Sep 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

pando85 commented Sep 5, 2026 •

edited

Loading

forkline-bot Bot commented Sep 5, 2026 •

edited

Loading